search

maximkulkin / esp-homekit

Apple HomeKit accessory server library for ESP-OPEN-RTOS
MIT License
1.1k stars 168 forks source link

Typo corrections #166

Closed Arlaz closed 3 years ago

maximkulkin commented 3 years ago

Thank you for PR. I agree with everything except changes to homekit_mdns.c. Thing is that (at least currently) homekit_mdns.c wasn't meant to be built on ESP_IDF as that platform has a decent builtin implementation of mDNS. Does it cause problems for you ? I guess, you're building it with CMake/idf.py. Right? Would it make sense to update CMake config to exclude that source file instead?

Arlaz commented 3 years ago

Thank you for your response, I didn't know that homekit_mdns.c was not intended to replace the ESP-IDF's one I was misled by the warnings of my IDE and the #ifded esp-open-rtos Thank you for this amazing library !

maximkulkin commented 3 years ago

Thank you for fixing this