search

maximkulkin / esp-homekit

Apple HomeKit accessory server library for ESP-OPEN-RTOS
MIT License
1.1k stars 168 forks source link

Update Accessory Categories #202

Closed AchimPieters closed 2 years ago

AchimPieters commented 2 years ago

Update Accessory Categories to HomeKit Accessory Protocol Specification, Non-Commercial Version , Release R2, page 252.

maximkulkin commented 2 years ago

Hi Achim. Changing category constants to plural is a breaking change with no extra benefit. As for changing QR code images to transparent ones, I'm still not sure what is the best way to do it. E.g. on Github page in dark mode QR code is hard to see. See the screenshot on how it appears for me:

qrcode in dark mode

I think what would make sense is to implement an option for QR code generator to either go white or transparent.

AchimPieters commented 2 years ago

Hi Max, That's right, and is certainly a major change. But it does follow the apple guidelines. Maybe ask the other people (slack) what they think? keep it that way or stick to the guidelines? what do you think?

As for the QR code, was not an adjustment. It is slipstreamed, but it might be a good idea to give the choice of a white background or transparent.