maximn
commented
2 years ago This is a very big PR that can't be mreged like this. It has WPF/executables that shoulnd't be a part of this project anyway.
If you want to add some capabilities, please do it in a separate short PR and I will review it.
Also, from a brief review - please make the code clear to readers. For example use named constants for magic numbers that I'm not sure what are they like 1.609344, 1.1515
⚠️ GitGuardian has uncovered 13 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Google API Key | 389ae03232cd814f9c480891f6a54d0c860464e7 | ConsoleApp1/Program.cs | [View secret](https://github.com/maximn/google-maps/commit/389ae03232cd814f9c480891f6a54d0c860464e7#diff-5263cc3e9f1fb9ca7d4d249b71330db7L23) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Google API Key | 389ae03232cd814f9c480891f6a54d0c860464e7 | GoogleMapsApi.Test/IntegrationTests/BaseTestIntegration.cs | [View secret](https://github.com/maximn/google-maps/commit/389ae03232cd814f9c480891f6a54d0c860464e7#diff-7cfaaa17ea0c06d81db6c61c71abf5ceL25) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Google API Key | 389ae03232cd814f9c480891f6a54d0c860464e7 | GoogleMapsApi.Test/IntegrationTests/DirectionsTests.cs | [View secret](https://github.com/maximn/google-maps/commit/389ae03232cd814f9c480891f6a54d0c860464e7#diff-a935ebfa09d3d353dc8ef9a47e5316c1L21) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Google API Key | 389ae03232cd814f9c480891f6a54d0c860464e7 | GoogleMapsApi.Test/StaticMaps.cs | [View secret](https://github.com/maximn/google-maps/commit/389ae03232cd814f9c480891f6a54d0c860464e7#diff-0f1eb994d11b01e15644871fef11888bL63) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Google API Key | 81e13fc2dbd81772c284d6efafc48db1a8fd173f | ConsoleApp1/Program.cs | [View secret](https://github.com/maximn/google-maps/commit/81e13fc2dbd81772c284d6efafc48db1a8fd173f#diff-5263cc3e9f1fb9ca7d4d249b71330db7L21) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Google API Key | 81e13fc2dbd81772c284d6efafc48db1a8fd173f | ConsoleApp1/Program.cs | [View secret](https://github.com/maximn/google-maps/commit/81e13fc2dbd81772c284d6efafc48db1a8fd173f#diff-5263cc3e9f1fb9ca7d4d249b71330db7R23) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Google API Key | 2da30a2f825453991f975637664991f4557a4221 | google-maps-api/MainViewModel.cs | [View secret](https://github.com/maximn/google-maps/commit/2da30a2f825453991f975637664991f4557a4221#diff-50330524feb839b6f8ef418a7fc55c27L15) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Google API Key | 6edfdcba87e563d241f54545adc9e6ade3148e06 | google-maps-api/MainViewModel.cs | [View secret](https://github.com/maximn/google-maps/commit/6edfdcba87e563d241f54545adc9e6ade3148e06#diff-50330524feb839b6f8ef418a7fc55c27R15) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Google API Key | 4b69affe8015f7f59f6ebb06b8372764e62b4900 | google-maps-api/MainViewModel.cs | [View secret](https://github.com/maximn/google-maps/commit/4b69affe8015f7f59f6ebb06b8372764e62b4900#diff-50330524feb839b6f8ef418a7fc55c27R16) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Google API Key | 16d4ce96b6cac44b347ec7a203ef60a343456119 | google-maps-api/MainViewModel.cs | [View secret](https://github.com/maximn/google-maps/commit/16d4ce96b6cac44b347ec7a203ef60a343456119#diff-50330524feb839b6f8ef418a7fc55c27R15) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Google API Key | 034b965fd76fcf8fd8c96214c49eb7681b6d7599 | google-maps-api/MainViewModel.cs | [View secret](https://github.com/maximn/google-maps/commit/034b965fd76fcf8fd8c96214c49eb7681b6d7599#diff-50330524feb839b6f8ef418a7fc55c27R17) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Google API Key | 034b965fd76fcf8fd8c96214c49eb7681b6d7599 | google-maps-api/MainViewModel.cs | [View secret](https://github.com/maximn/google-maps/commit/034b965fd76fcf8fd8c96214c49eb7681b6d7599#diff-50330524feb839b6f8ef418a7fc55c27L21) | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Google API Key | da1382238ed1d426e8012486153e2d8a19e1135d | google-maps-api/MainViewModel.cs | [View secret](https://github.com/maximn/google-maps/commit/da1382238ed1d426e8012486153e2d8a19e1135d#diff-50330524feb839b6f8ef418a7fc55c27R21) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/googleaiza#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!