search

maximumdata / markov-generator

A simple ES6 class for generating text using Markov chains. This should result in text that is similar in content and context to the supplied text sample, but (ideally) unique in concept.
11 stars 7 forks source link

This closes #1 by making analysis of word frequency case insensitive #2

Closed matthewlanders closed 7 years ago

matthewlanders commented 7 years ago

Hey @maximumdata, let me know what you think!

matthewlanders commented 7 years ago

Ah I just realized I probably should have added another test condition instead of modifying the first. I can do that this evening (I am in California). @maximumdata

maximumdata commented 7 years ago

@mmlanders23 I pulled your fork and tested it out, and it works great! The only thing I was going to mention was the test case, but you've already pointed it out.

Feel free to devise your own, but I think a test for this case would be to have a new array containing strings that have at least one letter capitalized in every word ( i.e. ['Test seNtence', 'anothEr teSt sentenCe'] ...etc ), send that into the generator, and then the test will pass if the output doesn't equal output.toLowerCase(). Either way, thanks for your contribution (and especially for commenting your addition)!

Ready to merge once a test is created.

matthewlanders commented 7 years ago

Hey @maximumdata. Test added! Let me know what you think.

maximumdata commented 7 years ago

@mmlanders23 Thanks a lot for your contribution! My holiday break was a bit longer than most, but I'll be reviewing this PR, and (most likely) merging it later today!

maximumdata commented 7 years ago

Merged! Thanks again for contributing!

matthewlanders commented 7 years ago

My pleasure!