maximuslotro / SignStory

A Minecraft mod for easily copying stories from a txt file onto signs.
GNU Lesser General Public License v3.0
4 stars 1 forks source link

Proposal for SignStory? #3

Closed Kofola45cz closed 2 years ago

Kofola45cz commented 2 years ago

@maximuslotro Hello dev,

maximuslotro commented 2 years ago

Thanks for the questions, let me answer them one by one.

  1. Making a Gui for the SignStory functions is on my list of things to add/tweak.
  2. I'm sorry that it is a bit confusing. I need to expand on the explanation of what pages are. Basically a page is as many words as the mod can fit into a 60 character string with cutting any words on 15 character intervals.
  3. The Upload/selection box staying on top of the select file dialog was always a issue with the signpicture mod, i will look into it and see if i can fix it from staying on top.
  4. Same as question 3? There is a bug with Signstory, that if the text ends on the fourth line of a sign, the mod will fail to load the file, and the select gui stays open. Tested your text file and found that it was the case for me.
  5. The next release changes how text is parsed and planed onto a sign, but in the meantime could you send a picture of what the text on the sign looks like after placing it. Tne next update, v1.0.3, will fix some of the issues that happened when i opened your text file.
  6. So far the only modifying of the mod i have done is adding under-the-hood changes to allow each to work without interfering with the other's functionality, I can see how having the messages say images instead of text and vice versa is an issue, I will work on that in the next release.

Thanks for your time. :)

maximuslotro commented 2 years ago

With version v1.0.3 release

  1. Added to to-do list
  2. Just load a text file normally, all a page is, is a 60 character long string broken up into 4, 15 character long lines that mod can place on a sign, so one page is one sign.
  3. Fixed with v1.0.3
  4. ^
  5. ^
  6. Added a separate file selection gui for text file in v1.0.3

Does this update solve your problems?

Kofola45cz commented 2 years ago

@maximuslotro Thank.

maximuslotro commented 2 years ago

@Kofola45cz Glad you understand what a page is. And for it showing the wrong text in the upper corner, i guess i didn't test for that. I think i have a setting turned off, that when on, it will show that. I will fix that in the next update sometime in the new few days. Thanks :)

Kofola45cz commented 2 years ago

@maximuslotro ok :)

Kofola45cz commented 2 years ago

@maximuslotro ok, I just tested SignStory v1.0.3

maximuslotro commented 2 years ago

Thanks i will look into the language bug, and an explanation of how text should be formatted, and change the loading message. Also do you mean the "back to game" button on the minecraft pause menu?

Kofola45cz commented 2 years ago

@maximuslotro yes, "back to game" in ESC Menu

maximuslotro commented 2 years ago

Ive added an example of how text is parsed and how you don't have to manually edit your text. https://github.com/maximuslotro/SignStory/blob/main/src/main/resources/Example_Text.txt. Will push an update soon that will fix all the items in the In Progress tab https://github.com/maximuslotro/SignStory/projects

maximuslotro commented 2 years ago

This Issue has been going on for a long time, through 2 versions, and keeps getting new stuff added to it. For the sake of keeping issue numbers clean, I'm closing this issue. If you have anymore questions or issues with future versions, please feel free to open an new issue. Have a good day. :)