maximuslotro / SignStory

A Minecraft mod for easily copying stories from a txt file onto signs.
GNU Lesser General Public License v3.0
4 stars 1 forks source link

I've found a few small errors. #8

Closed Kofola45cz closed 2 years ago

Kofola45cz commented 2 years ago
maximuslotro commented 2 years ago

1: Not a bug, the original mod would show this menu also when clicking a sign with the "option" option enabled, it allows for different options to show when clicking a valid SignPicture sign, like re-downloading the image or blocking the image, as an added bonus, I found that it allows for copy and pasting signs for non SignPicture signs, by selecting the place option after opening the gui from that menu.. The language path "signpic.gui.settings.load.text" error is a bug and was an issue with the original mod. Easy fix is to add the missing text link to the language file.

2:

  1. The file uploader could always be pulled out of the Minecraft window.
  2. Since it acts as a separate window, it wouldn't minimize when Minecraft minimizes.
  3. Since it is a separate window, it can be in front of the Minecraft window, and to fix the opener gui from always showing in front of the file selection dialog, I had to make the uploader gui to not always be on top of all windows.
  4. It has no effect on load_text functionality, even if it is hidden behind other windows, running the load command again will bring it to the front.

Thanks for the Feedback! 😃 Since there are no major bugs, i will probably release a fix later in this week.

Kofola45cz commented 2 years ago

Yeah, I get it, and yeah, luckily, that's all I could come up with. :)