search

maximvelichko / pyvera

A python library to control devices via the Vera hub
GNU General Public License v2.0
26 stars 31 forks source link

Handle comms failure better #148

Closed pavoni closed 3 years ago

pavoni commented 3 years ago

This PR improve the handling of communication failure

  1. It adds the ability to poll a device - although this isn't currently used
  2. Devices that have failed are reported as should_poll since https://github.com/pavoni/pyvera/issues/147 highlights that the subscription mechanism doesn't handle recovery reliably.

I investigated forcing a poll when refreshing a failed device - but it seemed to cause a lot of zwave traffic - and stop the normal services working! I think it need to be done far less often, with more care. This requires more careful thought.