Added support for scraping of NPCs

maxiride / pf2e-encounters

A Pathfinder 2 tool to balance encounters

https://maxiride.github.io/pf2e-encounters

Other

40 stars 15 forks source link

Added support for scraping of NPCs #35

Closed Jocarnail closed 1 year ago

Jocarnail commented 3 years ago

Scrape NPCs taking them from the NPC's table. The implementation of "getCreatureDetails" may be improved:

The Id field is taken from the href of the site, that contains the relative url for the creatures.
This contains already all the information to fetch the info on the creatures, be them monsters or NPCs.
It may be efficient to take as the creature's id the whole url and use it to fetch both monsters and npcs using the same function.

May try to do it in the next days.

Jocarnail commented 3 years ago

Changed scraping to take the entire relative url of the creatures ad ID: this allows to use the same function to scrape both monsters and npcs. Changes in the webui to be to open the correct page for both when one would like to consult the AoN. Now the address is directed by the id from the domain to the correct page (Eg: "Monsters.aspx" vs "NPCs.aspx")

maxiride commented 1 year ago

Closing the PR since the availability of the new python script in #46 should cover this