search

maxisam / mgob

MongoDB dockerized backup agent. Runs schedule backups with retention, S3 & SFTP upload, notifications, instrumentation with Prometheus and more.
https://maxisam.github.io/mgob/
MIT License
137 stars 19 forks source link

Dynamic statefulset replicas value #53

Closed vissarionas closed 1 year ago

maxisam commented 1 year ago

To be honest, I don't know if it will work correctly. I don't think the code handles multiple instances . But welcome to remove replica setting tho.

vissarionas commented 1 year ago

I will run more tests and let you know. My usecase for this is that to be used as an on/off switch for backups.

maxisam commented 1 year ago

i see. I guess I can merge you change for now and add a property like Enable to schedule, so you can set it any time you want?

maxisam commented 1 year ago

if you can add a line of warning in the value file like not supporting more than 1 replica, I think it should be good enough

vissarionas commented 1 year ago

We can do better, by creating a jsonSchema validating this replicasCount to not exceed 1 (untill there is the need to go higher anyway) https://helm.sh/docs/topics/charts/#schema-files

I'll update my pr, with some delay.