search

maxisam / mgob

MongoDB dockerized backup agent. Runs schedule backups with retention, S3 & SFTP upload, notifications, instrumentation with Prometheus and more.
https://maxisam.github.io/mgob/
MIT License
137 stars 19 forks source link

Adding fileName to gcloud command to allow usage of bucket name with path #60

Closed nicon89 closed 1 year ago

nicon89 commented 1 year ago

With this code it's possible to specify gcloud bucket name with path, for example:

gcloud:
  bucket: test-bucket/backups/mongo

It's already working like this in s3.

nicon89 commented 1 year ago

Btw, I found that in azure it creates a blob object in tmp/ directory: image

Maybe a good alternative would be in fact adding new optional variable, like backupPath?

nicon89 commented 1 year ago

@maxisam not sure why the checks have failed, looks like missing credentials?

maxisam commented 1 year ago

Sorry for that late reply. I am in vacation and out of states. And yes, it fails because of the missing credential. I need to make a better workflow

maxisam commented 1 year ago

You can try this https://hub.docker.com/layers/maxisam/mgob/dev.131/images/sha256-c08f4d1966c8b705d096ffe74ffdc8136590cd70a8bbabadcc2437f772c54071?context=explore

If it works as expected, I will push a new release. thx!

nicon89 commented 1 year ago

If it is same code, as the one pushed by me, then it must work - already using it on my side :)

maxisam commented 1 year ago

awesome, I will cut a release then