search

maxisam / ngx-clipboard

A pure angular clipboard directive
http://maxisam.github.io/ngx-clipboard/
MIT License
505 stars 93 forks source link

Angular 10 support #245

Closed davidshen84 closed 4 years ago

davidshen84 commented 4 years ago

Angular 10 requires at least tslib v2.0.0.

maxisam commented 4 years ago

upgrade to 10 should be pretty easy. Welcome to make a pull request : )

maxisam commented 4 years ago

please try 14.0.0-beta01

abdatta commented 4 years ago

Hi @maxisam ! Can you please merge this PR soon and publish it on npm? I have tried out 14.0.0-beta01 and it seems to work perfectly fine for me. Thanks for this helpful package!

davidshen84 commented 4 years ago

Or you can use the cdk clipboard https://material.angular.io/cdk/clipboard/api

On Sun, Oct 18, 2020, 23:57 Abhishek Datta notifications@github.com wrote:

Hi @maxisam https://github.com/maxisam ! Can you please merge this PR soon and publish it on npm? I have tried out 14.0.0-beta01 and it seems to work perfectly fine for me. Thanks for this helpful package!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maxisam/ngx-clipboard/issues/245#issuecomment-711164251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAQBTMBPELEL64SSWQTKVLSLLQ23ANCNFSM4O3N322Q .

abdatta commented 4 years ago

Thanks for that @davidshen84 ! Didn't realise angular/cdk had its own clipboard support. I guess this library is not needed anymore?

maxisam commented 4 years ago

@abdatta I just merged it. I will release it later It depends on you if you want to use this library. I will keep maintain this because I use it on my own production. If I don't use it anymore, I will let people know.

The reason I didn't merge because I think it is part of community's responsibility to confirm if it works when I release the beta.