search

maxisoft / ASFFreeGames

Collect free steam games while asf is running
GNU Affero General Public License v3.0
134 stars 3 forks source link

Free to play check doesn't ever match #16

Closed Faustvii closed 1 year ago

Faustvii commented 1 year ago

Describe the bug The regex capture group for permanently free doesn't ever match.

See here https://regex101.com/r/pPlxfe/2

This means the check on line ASFFreeGamesPlugin.cs#235 never matches.

Expected behavior I would expect it to not redeem permanently free games or be configurable if that's possible with plugins.

maxisoft commented 1 year ago

Hey, Thank for the report, indeed the regex is buggy on the f2p (free to play) part.

As you pointed fixing the regex is going to activate the check ASFFreeGamesPlugin.cs#235.
BTW I think that adding f2p games should reamins the default behavior (eg in case a previously f2p game is going to be non free) of this plugin.

I'll try to add an option/config file to configure this behavior.