Closed JourneyOver closed 1 year ago
woctezuma
commented
2 years ago This seems to be the game/sub in particular that it is failing on https://steamdb.info/sub/730490/
Do you already own sub/586694?
Not really sure on how to reproduce as I already owned the sub/game that this is failing on, since I got it through ASFclaim.
Which ones do you own: app/1180660, sub/730490, sub/586694?
maxisoft
commented
2 years ago Hey,
The issue is more about a misleading/missing log and documentation informations.
As a fresh user you may have thought the plugin is stuck on adding only 1 game but it's not. According to your logs and currently free steam games available, the plugin is working but I think there's no new free games that you don't own to be added for now.
The found 22 free games on reddit message means that the internal parser has found 22 addlicense entries on reddit.
That doesn't mean there is 22 free games going to be added for sure.
For instance a game fee offer may have expired or it's a dlc for a paid game that you don't own.
Request failed after 5 attempts! warnings:What you describe is revelent to the plugin logic.
The plugin checks if the steam user has already the game (using steamkit at this line) before adding it But for some reasons this check has false negatives (ie you already have a game title but it says you don't) on some titles/conditions.
So there's a workaround that is to tryhard to add the title (5 times) and internally blacklist it for 24hr in case of errors.
I'll edit log messages to make it more clear and document the Request failed behavior into the readme.
JourneyOver
commented
2 years ago @woctezuma
This seems to be the game/sub in particular that it is failing on steamdb.info/sub/730490
Do you already own
sub/586694?Not really sure on how to reproduce as I already owned the sub/game that this is failing on, since I got it through ASFclaim.
Which ones do you own:
app/1180660,sub/730490,sub/586694?
Going by what both steam and steamdb tell me I own all of these things, but on steamdb for sub/730490 instead of saying owned where the install usually is, it just says install if I go to any of the others (app/1180660 and sub/586694) though it says owned instead of install. If I go to https://store.steampowered.com/sub/730490 and try to add it (it says I already own the game in the items included section) it throws me to a site error page with:
OOPS, SORRY!
An error was encountered while processing your request:
This product is already available in your Steam library.Looking at things more I guess it's technically because I own the game already through the 2021 promotion sub/586694, but the sub/730490 is a newer promotion (2022) and ASFFreeGames isn't able to take that into account so it sits there and tries to continue to claim the 2022 promotion every 30 minutes?
@maxisoft
Hey,
The issue is more about a misleading/missing log and documentation informations.
As a fresh user you may have thought the plugin is stuck on adding only 1 game but it's not. According to your logs and currently free steam games available, the plugin is working but I think there's no new free games that you don't own to be added for now.
Okay so I think I understand, and it's pretty much the gist of what I had said above to woc about the whole Looking at things more I guess it's technically because I own the game already through the 2021 promotion `sub/586694`, but the `sub/730490` is a newer promotion (2022) and ASFFreeGames isn't able to take that into account so it sits there and tries to continue to claim the 2022 promotion every 30 minutes?
About found X free games on reddit
The
found 22 free games on redditmessage means that the internal parser has found 22addlicense entrieson reddit. That doesn't mean there is 22 free games going to be added for sure. For instance a game fee offer may have expired or it's a dlc for a paid game that you don't own.
Understood.
About
Request failed after 5 attempts!warnings:What you describe is revelent to the plugin logic.
The plugin checks if the steam user has already the game (using steamkit at this line) before adding it But for some reasons this check has false negatives (ie you already have a game title but it says you don't) on some titles/conditions.
So there's a workaround that is to tryhard to add the title (5 times) and internally blacklist it for 24hr in case of errors.
Understood as well, and since I had looked more into it I think I know the reasoning on why it continues to fail now as I had mentioned in this post. Main thing though is that it still is just tryhard trying to add the title and never blacklisted it even after going on 12 attempts of trying to tryhard add the title as of this message. Unless I misunderstood and it did blacklist it but it'll still try to add the title regardless until the promotion is over?
Resolution
I'll edit log messages to make it more clear and document the
Request failedbehavior into the readme.
That would be great.
Describe the bug A clear and concise description of what the bug is.
Just installed this after using ASFclaim for the longest time as I had been looking for something that just was a plugin instead for ASF instead of running a script.. Anyways not sure what is going on, it seems it started up just fine and it said it
found 22 free games on redditand started going through them but then it got to one and it just sits there and fails 5 times (Fail/Timeout) and stops until 30 minutes pass and then it tries to claim the same thing again but once again it just fails the 5 times (Fail/Timeout) and stops.This seems to be the game/sub in particulur that it is failing on https://steamdb.info/sub/730490/
To Reproduce Steps to reproduce the behavior: Not really sure on how to reproduce as I already owned the sub/game that this is failing on, since I got it through when I had ASFclaim running.
Expected behavior For it to see that it can't activate the product and move on.
Log ASF
Desktop (please complete the following information):
Additional context Add any other context about the problem here.