maxisoft / ASFFreeGames

Collect free steam games while asf is running
GNU Affero General Public License v3.0
121 stars 2 forks source link

Incompatibility of plugin version 1.4.1 with version 5.5.1.4 #54

Closed kotenok2000 closed 1 month ago

kotenok2000 commented 6 months ago

Describe the bug image

To Reproduce install plugin version 1.4.1 on asf 5.5.1.4

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

pjlalvarenga commented 5 months ago

Same for me! To Reproduce install plugin version 1.4.1 on asf 5.5.1.4 (Both Generic and x64)

Expected behavior should load but both are interrupted by exception and closes

Screenshots Same as user's

Desktop (please complete the following information):

OS: Windows 11 Education Browser: Chrome (but running without browser) Version 1.4.1 asf v5.5.1.4

Additional context Never tried the plugin before, so I don't know if it used to work in previous version combinations or when it started to have this error.

thierrybla commented 4 months ago

Anyone that has a workaround?

AndyShade commented 3 months ago

i use https://github.com/Citrinate/FreePackages for now

existful commented 3 months ago

Nop, there are different:

ASFFreeGames: Checks/Scans every 30 min reddit for new free games. FreePackages: Finds free packages on Steam and adds them to your account.

PhasecoreX commented 3 months ago

This is how I set mine up:

  "EnableFreePackages": true,
  "FreePackagesFilters": [
    {
      "Types": [
        "DLC"
      ]
    },
    {
      "Types": [
        "Game"
      ],
      "Languages": [
        "english"
      ],
      "IgnoreFreeWeekends": true,
      "NoCostOnly": true
    }
  ]

It'll grab all missing free DLC for games in your account, as well as all English language games that aren't just a weekend trial and aren't an "always free" type game.

That last option (NoCostOnly true) was important for me, as without it, it'll eventually add every free to play game, which a vast majority of them do not give out cards and don't count towards total game count.

Edit 2024-04-01: I updated the above config based on an issue I had, where brand new free games wouldn't be picked up immediately, and could potentially be missed if they were only free for the first 24 hours. Since there are so few NoCostOnly games/applications, there isn't really a reason to also be filtering by MinReviewScore.

maxisoft commented 1 month ago

Hey everyone,

Just fixed the issue with plugin version 1.4.1 not working with ASF 5.5.1.4 (issue #54). The new update in PR #65 sorts it all out.

Thanks to everyone who reported this and helped out by sharing info. Update to version 1.5.1 and you should be good to go.

Cheers, Maxisoft