Avoid passing 64-bit ints through LibraryLink

maxitg / SetReplace

C++/Wolfram Language package for exploring set and graph rewriting systems

MIT License

216 stars 43 forks source link

Avoid passing 64-bit ints through LibraryLink #648

Closed maxitg closed 3 years ago

maxitg commented 3 years ago

Changes

Closes #641.
We are currently passing 64-bit ints for disabled step specs, and an unsigned 32-bit for the seed initialization. WL LibraryLink does not support that on 32-bit platforms, so any calls to libSetReplace would fail.
This PR changes it to pass -1 and 31-bit ints instead, which should fix that issue.

Comments

Someone with a 32-bit system needs to confirm there is nothing else here I'm missing.

This change is

daneelsan commented 3 years ago

Does this mean:

It is failing because of something unrelated to these changes?

maxitg commented 3 years ago

@daneelsan, looks like it's failing because the seeds have changed (which they did since I'm now selecting the seeds from half the range). Maybe, I should pass the seed as a part of numbers instead to get around this and keep them backward compatible.

maxitg commented 3 years ago

@daneelsan, the seed is fixed now.