search

maxjcohen / transformer

Implementation of Transformer model (originally from Attention is All You Need) applied to Time Series.
https://timeseriestransformer.readthedocs.io/en/latest/
GNU General Public License v3.0
842 stars 165 forks source link

Pe/fix #36

Open shamoons opened 3 years ago

shamoons commented 3 years ago

There was an error that this fixes @maxjcohen

maxjcohen commented 3 years ago

Hi, if you're talking about the default value of pe_period, I would like to keep it as is. It's well documented too. Do tell me if there is something else I haven't seen here.

shamoons commented 3 years ago

I'll update it to keep the default period. The actual error is caused here: https://github.com/maxjcohen/transformer/blob/master/tst/transformer.py#L129

so I'll come up with another solution and update this PR accordingly

maxjcohen commented 3 years ago

I see, I'll let you work on it, and see if I can find a alternative later this week.

shamoons commented 3 years ago

Give me a day or 2 if you can and I'll have something

shamoons commented 3 years ago

@maxjcohen check the update. This should work now