Flash message marked as 'notice', when it should be 'error'.

maxjustus / sinatra-authentication

A sinatra extension wrapped in a gem that implements authentication/permissions with users stored in the database. Now with optional support for facebook connect

The Unlicense

476 stars 94 forks source link

Flash message marked as 'notice', when it should be 'error'. #46

Closed rupe closed 11 years ago

rupe commented 11 years ago

I'm not sure why this is happening, as it seems to be correct in the current code here, but the login error "The email or password you entered is incorrect." is being marked as ':notice', instead of ':error' in RackFlash. The content of the Rack::FLash object follows:

'#FlashHash @values={:notice=>"The email or password you entered is incorrect."} @cache={}'

cmhobbs commented 11 years ago

I can't seem to duplicate this issue. What version of the gem are you using?

rupe commented 11 years ago

Sorry, I don't recall, since posting I have fixed it and a few other issues (like changing to 'settings' , rack-flash3, and prepending "sa_" to view filenames, which helps) on my own fork. I didn't make a pull request as I've also removed parts of the original code that I would never need, but others may use (rufus tokyo etc).