search

maxjustus / sinatra-authentication

A sinatra extension wrapped in a gem that implements authentication/permissions with users stored in the database. Now with optional support for facebook connect
The Unlicense
478 stars 94 forks source link

Use rack-flash3 instead of rack-flash #47

Closed rupe closed 11 years ago

rupe commented 12 years ago

There are problems with the latest release of Rack and rack-flash. Rack-Flash3 addresses these issues, but sinatra-authentication does not recognize it as a replacement for rack-flash.

cmhobbs commented 11 years ago

Could you provide some more details or any specific errors you're getting? Thanks.

gojohnnygo commented 11 years ago

@nilmethod This link sums up the issue. https://github.com/nakajima/rack-flash/issues/8

The Sinatra FAQ is now linking to a forked version of rack-flash. http://www.sinatrarb.com/faq#flash

cmhobbs commented 11 years ago

Thanks for the input. I'll see what I can do.

ntboudreau commented 11 years ago

having this issue as well. would love to see a fix! :)

cmhobbs commented 11 years ago

Still on my list, sorry guys. I've been swamped lately. I'll see if I can't take a look at this on Thursday, I've got an opening then.

rupe commented 11 years ago

It should just be a matter of Pulling one of the many forks that have already implemented it. I've done it, plus fixed the settings/options deprecation issue, plus added a missing Flash message, added a "signup_closed" setting, and am in the middle of adding an Invite system for the signup module. I would have requested a pull, but this is my first time modifying another's work, so wanted to make sure everything was perfect before doing so ...

On Tuesday, November 27, 2012 at 5:18 PM, Christopher M. Hobbs wrote:

Still on my list, sorry guys. I've been swamped lately. I'll see if I can't take a look at this on Thursday, I've got an opening then.

— Reply to this email directly or view it on GitHub (https://github.com/maxjustus/sinatra-authentication/issues/47#issuecomment-10780076).

EHadoux commented 11 years ago

I may be mistaken but this commit (841cc6006e0fe7eb197561c6b0278bfaf5db35c2) doesn't already fix that?

cmhobbs commented 11 years ago

I believe the stated commit resolves the issue.