search

maxkeppeler / sheets-compose-dialogs

✨ Enhancing Android UIs: A Jetpack Compose Library supporting a wide range of common use-cases with Material Design 3 Dialogs, Popups, and Bottom Sheets. ✨
https://maxkeppeler.github.io/sheets-compose-dialogs/
Apache License 2.0
807 stars 38 forks source link

[Bug] Settings "12:00 AM" on the time picker resets the time to 12:00 PM instead #64

Closed Nek-12 closed 9 months ago

Nek-12 commented 1 year ago
  1. Open a time picker with AM/PM mode enabled
  2. Set the time to 12:00 AM explicitly i.e by tapping the AM/PM chip
  3. Click "OK"
  4. Dialog returns "12:00 PM"
  5. Set the time to 12:00 PM, choosing "PM" explicitly
  6. Dialog returns "00:00 AM".
luisguzman2098 commented 1 year ago

How can I get the selection value of AM or PM to put it in a string?

Nek-12 commented 1 year ago

How is this related to the issue? @luisguzman2098

Nek-12 commented 1 year ago

@maxkeppeler Any progress on this?

Nek-12 commented 1 year ago

@maxkeppeler Is there any progress on this? Would you be willing to merge a PR that fixes the issue?

maxkeppeler commented 1 year ago

Yes, contributions are welcome! Just no hacky workarounds but clean solutions. Considering my free time I would be very thankful for a PR that fixes this issue!

Nek-12 commented 1 year ago

Yes, I noticed that you are very busy lately. I'll prepare a PR, this should be a simple but very important fix

maxkeppeler commented 9 months ago

Where's the PR? 😆

Nek-12 commented 8 months ago

Where's the PR? 😆

I completely forgot about this 🙃 Thanks for fixing the bug