search

maxkeppeler / sheets

⭐ ‎‎‎‏‏‎ ‎Offers a range of beautiful sheets (dialogs & bottom sheets) for quick use in your project. Includes many ways to customize sheets.
https://maxkeppeler.github.io/sheets/
Apache License 2.0
921 stars 77 forks source link

Input Sheet validation bug #22

Closed russellbanks closed 3 years ago

russellbanks commented 3 years ago

Describe the bug On the Input Sheet, when a user inputs something that is invalid, the positive button goes invisible to indicate an invalid response, but the user is still able to press it and go through with the action.

Library Version: 1.1.0

To Reproduce Steps to reproduce the behavior:

  1. Have an input into an input sheet that is deemed invalid by the validation listener.
  2. Click where the positive button would be.

Expected behavior The user should not be able to go through with the action if the given input is invalid.

Screenshots I've attached two videos here that show the issue. The first one is of an implementation in my app. The second is from the sample app. Implementation in my app Sample app

Additional context This occurs on the sample app, too.