search

maxkeppeler / sheets

⭐ ‎‎‎‏‏‎ ‎Offers a range of beautiful sheets (dialogs & bottom sheets) for quick use in your project. Includes many ways to customize sheets.
https://maxkeppeler.github.io/sheets/
Apache License 2.0
921 stars 77 forks source link

crashes on configuration change #24

Closed mohamadjavadx closed 3 years ago

mohamadjavadx commented 3 years ago

Describe the bug the sample app crashes on configuration change while showing some bottom-sheets

Library Version: 1.1.1

To Reproduce open a multipleChoices bottom-sheet and rotate phone

Expected behavior the app should not crash and also app should maintain state of bottom-sheet and selected options

Additional context maybe some navigationComponent-ish changes could help

maxkeppeler commented 3 years ago

Found the issue. You are right, instead of calling the bottom sheet again, the bottom sheet should maintain the state and data and show up again after the configuration change. Will work on it soon.

mohamadjavadx commented 3 years ago

thanks for quick response, also check out fragment new dependency (1.3.0-rc01) it's pretty much stable and provide new ways to do things