search

maxkeppeler / sheets

⭐ ‎‎‎‏‏‎ ‎Offers a range of beautiful sheets (dialogs & bottom sheets) for quick use in your project. Includes many ways to customize sheets.
https://maxkeppeler.github.io/sheets/
Apache License 2.0
921 stars 77 forks source link

There should be a drawable argument that is actually a drawable and not a resource #45

Closed rosenpin closed 3 years ago

rosenpin commented 3 years ago

Currently the InfoSheet for example takes a resource for drawable, beside the fact that this is misleading, it limits the usage of this library. In many cases drawables are loaded at run time and have no resource id.

I believe the default behavior should be to take an actual drawable as an argument, and add an option to supply a drawable resource as a different argument if you think it's necessary

maxkeppeler commented 3 years ago

I created this library for my personal needs at the beginning and always used drawable by id. But that's a basic thing and can be added! I will try to add it this weekend.

rosenpin commented 3 years ago

Nice!
Thanks