maxkeppeler / sheets

⭐ ‎‎‎‏‏‎ ‎Offers a range of beautiful sheets (dialogs & bottom sheets) for quick use in your project. Includes many ways to customize sheets.
https://maxkeppeler.github.io/sheets/
Apache License 2.0
921 stars 77 forks source link

Using the new Kotlin JVM IR with Sheets causes a compilation error #57

Closed russellbanks closed 3 years ago

russellbanks commented 3 years ago

Describe the bug The Kotlin team have rewritten the JVM compiler and this becomes default in Kotlin 1.5.0. However, attempting to use Sheets on an app that uses either the new IR on Kotlin 1.4.32 or Kotlin 1.5.0 where the new IR becomes the default compiler for Kotlin throws TypeAliasDescriptor expected: class NegativeListener (not found).

Not knowing that Sheets was causing the issue, I commented on an issue on JetBrains YouTrack to which an employee responded showing the cause of the error. I have attached this under additional context. I have also attached two pipelines that show the thrown error on my project, the line in Sheets that causes the error and another issue that has more information about the problem in depth.

Library Version: 2.1.4

To Reproduce Steps to reproduce the behavior:

  1. Add useIR = true under kotlinOptions{} in Gradle or use Kotlin 1.5.0 where the new IR is default.

Expected behavior The app should be able to compile with the new IR while using Sheets.

Additional context

maxkeppeler commented 3 years ago

If they have rewritten the JVM compiler, where the code didn't lead to any issue, but now does with the new IR, isn't that something they have to work on? I'm not sure what I can do after checking out the links.

I can not replicate it within the project running the sample with Kotlin 1.4.32 and the new IR. Can you replicate it there as well?

russellbanks commented 3 years ago

I've tried compiling the sample app with both Kotlin 1.5.0-RC and 1.4.32 with the new IR and this doesn't bring up an error, which is weird. I originally thought this would be something that would require a bit of migration but for now I'll close this issue and hope that the Kotlin team fix this soon. If it does require migration, I'll re-open the issue.

russellbanks commented 3 years ago

Fixed in Kotlin 1.5.20-RC with this commit