Fix objective c import in api.md

maxkomarychev / react-native-ultimate-config

Config that works

MIT License

260 stars 31 forks source link

Fix objective c import in api.md #134

Open thorgas opened 1 year ago

thorgas commented 1 year ago

hi @maxkomarychev, thank you very much for this library! Not sure if something in my setup is wrong, but in order to use the env variables in Objective-c I had to change the import from your docs (https://github.com/maxkomarychev/react-native-ultimate-config/blob/master/docs/api.md#objective-c) to #import <react_native_ultimate_config/ConfigValues.h>

maxkomarychev commented 11 months ago

Hi, I have not experienced this. Could you please share more information about your setup? (version of Xcode, iOS deployment target, whether swift is used or no etc).

Thanks!

thorgas commented 11 months ago

Hi, my Xcode version is Version 14.3.1 (14E300c), IPHONEOS_DEPLOYMENT_TARGET = 14.0, we are using a bridging header and we have a module integrated via spm via Frameworks, Libraries, and embedded Content in Xcode under TARGETS -> General. RN version is 0.71.0. Above mentioned import happens in AppDelegate.mm

dkulakov commented 5 months ago

Hi @thorgas , thanks for your PR, that's really helpful for me!

@maxkomarychev this PR is fix for the issue https://github.com/maxkomarychev/react-native-ultimate-config/issues/144

alexkev commented 3 months ago

Thanks @thorgas for your PR!