search

maxkomarychev / react-native-ultimate-config

Config that works
MIT License
262 stars 31 forks source link

Is part of README redundant? #5

Closed grubstarstar closed 4 years ago

grubstarstar commented 4 years ago

In the docs it says these files will be updated:

android/src/main/java/com/reactnativeultimateconfig/ConfigValues.java
ios/ConfigValues.h

but they don't seem to exist in my project and yet the config seems to work fine. Is this part of the README now redundant?

grubstarstar commented 4 years ago

Oh I just realised this is in the root of the react-native-ultimate-config module itself, not my project.

In which case, where should I run git update-index --assume-unchanged android/src/main/java/com/reactnativeultimateconfig/ConfigValues.java ios/ConfigValues.h from?

From within node_module/react-native-ultimate-config?

Just trying to clarify what this achieves.

maxkomarychev commented 4 years ago

hey @grubstarstar !

this part of README is relevant in case if you're developing library itself, it's not needed when you just use it, please refer to api and quickstart docs for usage tips

sorry for confusion, I guess I'd need to put that part under more clear title

maxkomarychev commented 4 years ago

Just trying to clarify what this achieves.

these files I mentioned are being codegenerated and overwritten constantly when developing and testing a library, therefore when I'm in dev cycle I mark these files as "unchanged" so that they do not appear in my git diff and I don't commit them by accident. gitignore does not help here because I do need these files to be in repo but at the same time I only need them to be updated whenever I explicitly mark them to

actually good question, I guess I can just create these files in prepublish script and remove from git since I don't need them in git, I do need them in distribution :)

grubstarstar commented 4 years ago

Ah that makes sense! Thanks for the quick response. The module worked a treat on both iOS and Android 🙂