search

maxkomarychev / react-native-ultimate-config

Config that works
MIT License
261 stars 31 forks source link

3.4.0 doesn't support React 17 #71

Closed bill-dai closed 3 years ago

bill-dai commented 3 years ago

Upgraded to React Native 0.65.1 today and it requires React 17.0.2, but RNUC doesn't support it.

Found: react@17.0.2 npm ERR! node_modules/react npm ERR! react@"17.0.2" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer react@"^16.8.1" from react-native-ultimate-config@3.4.0 npm ERR! node_modules/react-native-ultimate-config npm ERR! react-native-ultimate-config@"*" from the root project

Should I use the -- force option to force the dependency conflict?

maxkomarychev commented 3 years ago

hi @bill-dai

thank you for this report, I believe peer dependency of react has gotten here by a mistake - there is nothing in this library why you would need react for.. I'll issue a new version soon

maxkomarychev commented 3 years ago

please try version 3.4.1

feel free to reopen if this still happens

thanks for choosing react-native-ultimate-config :)