maxkonovalov / MKRingProgressView

⭕️ Ring progress view similar to Activity app on Apple Watch
MIT License
1.57k stars 136 forks source link

Same startColor and endColor produces unnecessary gradient #48

Closed xquezme closed 5 years ago

xquezme commented 5 years ago

I assume, this because library uses !== instead of !=, but .cgColor always produce different instance. And pointers are not equal.

screenshot 2019-02-21 at 00 53 15

Example:

let view = RingProgressView()
view.startColor = .red
view.endColor = .red

Workaround:

let view = RingProgressView()
let color = UIColor.red.cgColor
let layer = (view.layer as! RingProgressLayer)
layer.startColor = color
layer.endColor = color
maxkonovalov commented 5 years ago

Yes, indeed, in some cases the check would produce incorrect result, I pushed a fix.