Added Typescript Definitions

maxkordiyak / react-native-dropdown-autocomplete

Autocomplete input with dropdown modal component for React native. Useful for pages with multiple autocomplete's.

MIT License

100 stars 51 forks source link

Added Typescript Definitions #12

Closed PaitoAnderson closed 5 years ago

PaitoAnderson commented 5 years ago

Not sure if you are interested in supporting Typescript users...but this could really help some of us. Thanks!

maxkordiyak commented 5 years ago

Thank you for implementing!

maxkordiyak commented 5 years ago

I would like to re-implement this component using Typescript internally but now I don't have time to do this. Also instead of passing custom styles which looks not clean to me, I would maybe prefer passing custom components and wire them together inside

PaitoAnderson commented 5 years ago

@maxkordiyak That would be awesome, thanks for sharing your thoughts.

Just started looking at this library today, and might do a couple more PRs based on what I'm seeing.

1) Extacting utils/api/index.js as right now it is expecting a single query string parameter called search, and data and success properties in the result which isn't that flexible. 2) The placeholder is still showing as I type, not sure why yet.

Cool?

maxkordiyak commented 5 years ago

Yes, please go ahead, it would be great to see improvements. Again, thanks for contributing!