Add x:DataType parameter to all views to improve runtime performance

maxkoshevoi / NureTimetable

Xamarin Forms application for viewing timetable of groups, teachers and rooms of the Kharkiv National University of Radio Electronics

https://play.google.com/store/apps/details?id=com.whitebox.nuretimetable

41 stars 5 forks source link

Add x:DataType parameter to all views to improve runtime performance #32

Closed maxkoshevoi closed 4 years ago

maxkoshevoi commented 4 years ago

After transitioning to MVVM pattern, there is a performance hit because Xamarin needs to use reflection to communicate with ViewModel. By spesifying x:DataType parameter for Views with their respective ViewModels we allow Xamarin to link them at compile time thus improving rintime performance.

More info: https://docs.microsoft.com/en-us/xamarin/xamarin-forms/app-fundamentals/data-binding/compiled-bindings

maxkoshevoi commented 4 years ago

Closed with notes:

x:DataType wasn't set for AddEntityPage cause it has several ViewModels (this page used as three different pages)
x:DataType wasn't set for ListViews on LessonSettingsPage cause ViewModels are generics for them
For some reason Spans inside Labels don't inherit x:DataType attribute, so it needs to be set again:
Same goes for ContentPage.Behaviors (behaviors in other places are working as expected) and ContentPage.ToolbarItems:

maxkoshevoi commented 4 years ago

So, it's not all sunshine and rainbows after all.. App now has this issue: https://github.com/xamarin/Xamarin.Forms/issues/6698