search

maxkueng / node-lastfmapi

A Last.fm API client library wrapper with a simple and clean interface.
MIT License
52 stars 15 forks source link

update lastfm dependency version #3

Open Kikobeats opened 10 years ago

Kikobeats commented 10 years ago

Hey man, Why not update lastfm version? break the code?

:)

maxkueng commented 10 years ago

Thanks for the info! I wasn't aware of the new release of lastfm. I will check it out and see if it would break anything. Unfortunately there are no automated tests (yet) so I will have to create them or test manually.

If you have some time and want to help out I'd be glad if you could try to upgrade the dependency and see if it still works.

Kikobeats commented 10 years ago

I create a little module for my framework that use this API and I have a little tests (only for check if works fine with the most important options):

https://github.com/sailorjs/sailor-module-lastfm

check test folder!

2014-09-05 11:19 GMT+02:00 Max Kueng notifications@github.com:

Thanks for the info! I wasn't aware of the new release of lastfm. I will check it out and see if it would break anything. Unfortunately there are no automated tests (yet) so I will have to create them or test manually.

If you have some time and want to help out I'd be glad if you could try to upgrade the dependency and see if it still works.

— Reply to this email directly or view it on GitHub https://github.com/maxkueng/node-lastfmapi/issues/3#issuecomment-54602564 .

maxkueng commented 10 years ago

Thanks! Will check it out. Are there any important changes to lastfm that you need in your module? i.e. is it urgent?

Kikobeats commented 10 years ago

About this, I would like that all functions accept a object as parameter that follow the same pattern.

Check in the next link that I try to access passing and object and later, if fails, try to fix it: https://github.com/sailorjs/sailor-module-lastfm/blob/master/api/services/LastFMService.coffee#L23

:(

2014-09-05 13:27 GMT+02:00 Max Kueng notifications@github.com:

Thanks! Will check it out. Are there any important changes to lastfm that you need in your module? i.e. is it urgent?

— Reply to this email directly or view it on GitHub https://github.com/maxkueng/node-lastfmapi/issues/3#issuecomment-54613778 .