search

maxkw / evolution

0 stars 0 forks source link

Pythonic loops #8

Closed polyguo closed 8 years ago

polyguo commented 8 years ago

Replace list comprehensions for explicit loops

maxkw commented 8 years ago

just be clear: this shouldn't be a hard and fast rule... but if there are nested ifs in the loop its probably a bad idea. a good heuristic is the code taking up no more than two lines when limited to 80 characters.

maxkw commented 8 years ago

e.g., line 292. a single iterator is fine... don't nest conditionals.