search

maxlapshin / mysql2postgres

Mysqldump, writing in postgresql format
MIT License
711 stars 156 forks source link

Fix to prevent nil error for NULL times #26

Closed nesquena closed 9 years ago

nesquena commented 13 years ago

Times can be NULL in the database and before this patch, this would crap out the script. Please pull in this change so that NULL times are handled properly. Thanks for this by the way it is seriously gold as we try to move to Postgres from mysql!

nesquena commented 13 years ago

Added a bunch of other handy improvements to this script. Please consider pulling them in. With these changes, the script was much more robust to my mysql database conversion.

tardate commented 13 years ago

Hi Nathan, these look like good additions - I was about to merge your changes on my branch but held off because it looked like I needed to write some tests to do so.

Are you able to add some tests for the problems/fixes you've addressed? It makes it much easier to safely integrate changes coming from many people.

nesquena commented 13 years ago

I ended up making more changes here than I expected. Had forgotten about this pull request. I would like to get around to adding tests soon. We completed the postgres merge using this updated version of the script. Thanks again for releasing this excellent gem!