support custom datatypes

maxlath / wikibase-cli

read and edit a Wikibase instance from the command line

MIT License

227 stars 24 forks source link

Open persona0591 opened 1 year ago

persona0591 commented 1 year ago

Hi!

Thanks for this library - very helpful! :)

I'm trying to add a claim ("P1") to an entity ("Q1") in a Wikibase instance. This instance has its own, custom datatype for "P1" (named "urix").

If I run e.g.

wb add-claim Q1 P1 "test"

... then the response is:

unsupported datatype: urix. Please open an issue at ...

How can I use this library for custom datatypes?

maxlath commented 1 year ago

Hi! That's the first time I encounter that problem, so it had not been considered until now for this lib, I'm afraid ^^ The problem comes from wikibase-edit, which doesn't know how to validate and format that unknown datatype

persona0591 commented 1 year ago

Hi @maxlath Thank you - good to know! Do you have plans to support this feature? Or do you know of a workaround?

maxlath commented 1 year ago

Different possibilities:

wikibase-edit could support declaring custom datatypes in some way: we would need a way to declare a statement builder function for that datatype, or to declare that that custom datatype has the same shape as another known datatype
you could fork wikibase-edit to add the desired statement builder function, possibly by just aliasing the new datatype to an existing builder, as it already done for most datatypes

persona0591 commented 1 year ago

Hi @maxlath Thank you, much appreciated!