maxlath / wikibase-cli

read and edit a Wikibase instance from the command line
MIT License
227 stars 24 forks source link

Create Dockerfile #32

Closed addshore closed 6 years ago

addshore commented 6 years ago

This Dockerfile easily enabled the command to be run.

adam@adsh MINGW64 ~/dev/git/github/maxlath/wikidata-cli (docker)
$ docker run --rm wikibase/wikidata-cli --version
4.19.0

I'm not sure what we want to call the image or where we want to push it. Perhaps this repo should actually be called wikibase-cli? ;) Also not sure how to include this in the README

maxlath commented 6 years ago

nice! I'm not completely up-to-speed with Docker, when I run docker run --rm wikibase/wikidata-cli --version, I get the following message:

Unable to find image 'wikibase/wikidata-cli:latest' locally
docker: Error response from daemon: pull access denied for wikibase/wikidata-cli, repository does not exist or may require 'docker login'.
See 'docker run --help'.

Do I need to login to access it?

addshore commented 6 years ago

So I haven't pushed it to anywhere on docker hub. If you checkout the change and run the following in the wikidata-cli directory you should get it running

docker build -t wikibase/wikidata-cli ./
docker run --rm wikibase/wikidata-cli --version
addshore commented 6 years ago

You could make an account on hub.docker.com and then make an image called maxlath/wikidata-cli and use "docker push" to push the image! You can also setup auto building!

addshore commented 6 years ago

Whhheeee :D

maxlath commented 6 years ago

I published the image and added a note in the readme, thank you for your help!