search

maxmarinich / react-alice-carousel

React responsive component for building content galleries, content rotators and any React carousels
MIT License
842 stars 92 forks source link

Error when using arrow navigation with React 16 (Fiber) #3

Closed ghost closed 7 years ago

ghost commented 7 years ago

Hi, I tried using the lib with React 16 and it crashes when you are navigating between slides.

Here is the error: http://prntscr.com/gzfzzw

maxmarinich commented 7 years ago

@gopchi Hi, it looks like you have a conflict in the dependencies of the project. I have created a branch react-16-example in which the component works as expected.

Please check again and if you'll see that the problem still exists please provide a code sample for possible analysis.

ryguyrocks commented 6 years ago

I'm getting the same error on a fresh React App, I'm using the example responsive code you provided in the read me. The slider renders fine but the arrows don't work and throw this error.

ReactBaseClasses.js:64 Uncaught TypeError: this.updater.enqueueCallback is not a function at AliceCarousel../node_modules/react-alice-carousel/node_modules/react/lib/ReactBaseClasses.js.ReactComponent.setState (ReactBaseClasses.js:64) at AliceCarousel._slideToItem (react-alice-carousel.js:770) at AliceCarousel._this._slideNext (react-alice-carousel.js:379) at HTMLUnknownElement.callCallback (react-dom.development.js:542) at Object.invokeGuardedCallbackDev (react-dom.development.js:581) at Object.invokeGuardedCallback (react-dom.development.js:438) at Object.invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:452) at executeDispatch (react-dom.development.js:836) at executeDispatchesInOrder (react-dom.development.js:858) at executeDispatchesAndRelease (react-dom.development.js:956) at executeDispatchesAndReleaseTopLevel (react-dom.development.js:967) at Array.forEach () at forEachAccumulated (react-dom.development.js:935) at processEventQueue (react-dom.development.js:1112) at runEventQueueInBatch (react-dom.development.js:3607) at handleTopLevel (react-dom.development.js:3616) at handleTopLevelImpl (react-dom.development.js:3347) at batchedUpdates (react-dom.development.js:11082) at batchedUpdates (react-dom.development.js:2330) at dispatchEvent (react-dom.development.js:3421) ./node_modules/react-alice-carousel/node_modules/react/lib/ReactBaseClasses.js.ReactComponent.setState @ ReactBaseClasses.js:64 _slideToItem @ react-alice-carousel.js:770 AliceCarousel._this._slideNext @ react-alice-carousel.js:379 callCallback @ react-dom.development.js:542 invokeGuardedCallbackDev @ react-dom.development.js:581 invokeGuardedCallback @ react-dom.development.js:438 invokeGuardedCallbackAndCatchFirstError @ react-dom.development.js:452 executeDispatch @ react-dom.development.js:836 executeDispatchesInOrder @ react-dom.development.js:858 executeDispatchesAndRelease @ react-dom.development.js:956 executeDispatchesAndReleaseTopLevel @ react-dom.development.js:967 forEachAccumulated @ react-dom.development.js:935 processEventQueue @ react-dom.development.js:1112 runEventQueueInBatch @ react-dom.development.js:3607 handleTopLevel @ react-dom.development.js:3616 handleTopLevelImpl @ react-dom.development.js:3347 batchedUpdates @ react-dom.development.js:11082 batchedUpdates @ react-dom.development.js:2330 dispatchEvent @ react-dom.development.js:3421

Here is my package.json: { "name": "test-app", "version": "0.1.0", "private": true, "dependencies": { "react": "^16.2.0", "react-dom": "^16.2.0", "react-scripts": "1.1.0" }, "scripts": { "start": "react-scripts start", "build": "react-scripts build", "test": "react-scripts test --env=jsdom", "eject": "react-scripts eject" }, "devDependencies": { "react-alice-carousel": "^1.7.2" } }

maxmarinich commented 6 years ago

@ryguyrocks please update version to 1.7.5