Upgrade WASM to support go 1.12+

maxmcd / webtty

Share a terminal session over WebRTC

https://maxmcd.github.io/webtty/

MIT License

2.71k stars 143 forks source link

Upgrade WASM to support go 1.12+ #31

Closed maxmcd closed 3 years ago

maxmcd commented 3 years ago

related to #29

@Sean-Der we might want to dockerize the the build process, or somehow enforce building with go 1.15, since wasm_exec.js is a moving target. Thoughts?

Additionally I could add to your github actions tests to test this build, might be a good idea.

Sean-Der commented 3 years ago

:fire: you did this so quick, thank you so much

In the Github action I can pin node/Go versions. My only hesitation for doing Docker is that it is another moving piece to update/requires auth to upload the new image. If we use Github actions a PR can fix everything.

maxmcd commented 3 years ago

@Sean-Der sounds good to me. I had forgotten all the dockerfile stuff was for circleci. I removed all the dockerfiles.