search

maxmcd / webtty

Share a terminal session over WebRTC
https://maxmcd.github.io/webtty/
MIT License
2.71k stars 143 forks source link

Support for macOS? #40

Closed prologic closed 2 years ago

prologic commented 2 years ago

This does not seem to build for macOS 😢

$ go install github.com/maxmcd/webtty@master
go: downloading github.com/maxmcd/webtty v0.4.2-0.20210101200840-72801c8b8bc1
# golang.org/x/sys/unix
go/pkg/mod/golang.org/x/sys@v0.0.0-20200930185726-fdedc70b468f/unix/syscall_darwin.1_13.go:29:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200930185726-fdedc70b468f/unix/zsyscall_darwin_amd64.1_13.go:27:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200930185726-fdedc70b468f/unix/zsyscall_darwin_amd64.1_13.go:40:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200930185726-fdedc70b468f/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200930185726-fdedc70b468f/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200930185726-fdedc70b468f/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200930185726-fdedc70b468f/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200930185726-fdedc70b468f/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200930185726-fdedc70b468f/unix/zsyscall_darwin_amd64.go:105:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200930185726-fdedc70b468f/unix/zsyscall_darwin_amd64.go:121:3: //go:linkname must refer to declared function or variable
go/pkg/mod/golang.org/x/sys@v0.0.0-20200930185726-fdedc70b468f/unix/zsyscall_darwin_amd64.go:121:3: too many errors
Sean-Der commented 2 years ago

Hey @prologic

Are you using a M1? I can upgrade all the libraries to the latest version, but I don't have a machine to test. Would you mind testing a branch if I created it tonight?

prologic commented 2 years ago

Intel Mac here and happy to test 👌

maxmcd commented 2 years ago

@Sean-Der I can test on an M1 if needed

Sean-Der commented 2 years ago

@prologic @maxmcd give that a shot https://github.com/maxmcd/webtty/pull/41 ! If it works will give it a merge :)

go install github.com/maxmcd/webtty@upgrade-pion

maxmcd commented 2 years ago

@Sean-Der successful installs on both M1 and linux/amd64.

Sean-Der commented 2 years ago

Great! Merged+Tagged+Released https://github.com/maxmcd/webtty/releases/tag/v0.5.1

prologic commented 2 years ago

@Sean-Der Same here 🥳 (sorry different timezones!)