maxmilton / new-tab

⚡ A high-performance browser new tab page that gets you where you need to go faster.
https://chrome.google.com/webstore/detail/new-tab/cpcibnbdmpmcmnkhoiilpnlaepkepknb
MIT License
86 stars 7 forks source link

Bookmark folder popups don't show and hide at the correct time #1122

Closed maxmilton closed 3 years ago

maxmilton commented 3 years ago

On the next branch the logic behind rendering bookmark subfolders has been rewritten.

Before it was CSS based for layout etc. which was great for performance and simplifying logic but had limitations like the inability to scroll a long list of bookmark items or control folder position when overflowing the screen. The new logic is JS based so there's no longer any issues with position and layout, however, the implementation is still incomplete.

Current issues:

Many things here differ from the Chrome UX because Chromium is designed for good a11y however this extension favours speed.

maxmilton commented 3 years ago

Only difference from my original write up is that there's no delay before showing a folder popup. It's not actually that annoying to trigger it by accident and it actually feels very responsive with the immediate open.

maxmilton commented 3 years ago

For my own future reference, the reason we had an open delay before was only on nested folders because it's too easy to open the wrong folder. When moving the mouse between the target folder and its popup, if you happen to mouse over another folder your target folder's popup will be closed.

We'll still need to fix this in future so I created a new issue: https://github.com/maxmilton/new-tab/issues/1152