maxmind / GeoIP2-perl

Perl API for MaxMind's GeoIP2 web services and databases
https://metacpan.org/release/GeoIP2/
Other
18 stars 11 forks source link

Is the test dependency on Code::TidyAll::Plugin::SortLines::Naturally needed? #35

Closed Grinnz closed 8 years ago

Grinnz commented 8 years ago

As far as I can tell, Code::TidyAll is not used in any tests, other than generated author and release tests which are not run by users. This introduces a significant dependency tree to the distribution. If it is needed for author or release testing, it should be a DevelopRequires prereq.

oschwald commented 8 years ago

Thanks for pointing that out. It indeed should be a develop dependency.

oschwald commented 8 years ago

Fixed in a4065b2968f2351ef9ab4467ffdd777557c3dedb