search

maxmind / GeoIP2-php

PHP API for GeoIP2 webservice client and database reader
https://maxmind.github.io/GeoIP2-php/
Apache License 2.0
2.3k stars 274 forks source link

Update .gitattributes #190

Closed reedy closed 2 years ago

reedy commented 2 years ago

Is examples/benchmark.php really needed to?

oschwald commented 2 years ago

I think it makes sense to have the examples in the GitHub tarball and zip files. Adding them here would prevent that.

There has been some debate about whether we should use .gitattributes in this matter at all. See, e.g., https://github.com/maxmind/MaxMind-DB-Reader-php/issues/55.

I'll merge this for now though as it just updates the existing list to be more correct. Thanks!