maxmind / GeoIP2-php

PHP API for GeoIP2 webservice client and database reader
https://maxmind.github.io/GeoIP2-php/
Apache License 2.0
2.3k stars 274 forks source link

Use more specific reader variable names #203

Closed ravage84 closed 1 year ago

ravage84 commented 1 year ago

Since a Reader loads a specific file (and presumably) does not allow to load multiple files at once, it would need more than one instance of them to search in more than one databse file. Thus, it would need more than one variable that contains a Reader.

Naming them just $reader will potentially lead to code conflicts for new users (blindly) copy & pasting the various examples.