Update Guzzle version - Githubissues

maxmind / GeoIP2-php

PHP API for GeoIP2 webservice client and database reader

https://maxmind.github.io/GeoIP2-php/

Apache License 2.0

2.33k stars 276 forks source link

Update Guzzle version #27

Closed mchristie closed 10 years ago

mchristie commented 10 years ago

I've updated the Guzzle version to "dev-master" and all unit tests pass.

coveralls commented 10 years ago

Coverage remained the same when pulling e574beb3abb23a49aaca2fd7c27b6ce442027ce9 on mchristie:master into 36624ae87a6977450c13cb91fec42c06b89d3b45 on maxmind:master.

oschwald commented 10 years ago

I don't think we want to be tracking master as unintended code breakage may be merged. What problem are you trying to fix? We currently use the latest version 3 release.

mchristie commented 10 years ago

I had a version conflict with another package which required Guzzle 4 and dev-master seemed like the easiest way to fix it. Although I guess you're right it's probably not ideal!

oschwald commented 10 years ago

According to the Guzzle FAQ, it should be possible to use Guzzle 3 and 4 in the same project without issue.

Unfortunately, Guzzle 4 dropped support for PHP 5.3, which many of our users still use.