search

maxmind / GeoIP2-php

PHP API for GeoIP2 webservice client and database reader
https://maxmind.github.io/GeoIP2-php/
Apache License 2.0
2.33k stars 276 forks source link

Update composer.json to require bcmath #6

Closed nrbrook closed 10 years ago

nrbrook commented 10 years ago

I tried running GeoIP2 on a box without the BC Math PHP extension and got the error:

Fatal error: Call to undefined function MaxMind\Db\Reader\bcadd() in /home/vagrant/Akkroo/publish/vendor/maxmind-db/reader/src/MaxMind/Db/Reader/Decoder.php on line 252

The library should depend on ext-bcmath to ensure users do not run in to this problem.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 530a207175486e62dcabbfb0eaa217125d95d0d1 on nrbrook:patch-1 into 8bf84426072c47846ab0e7fb353672d4e24d3637 on maxmind:master.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 530a207175486e62dcabbfb0eaa217125d95d0d1 on nrbrook:patch-1 into 8bf84426072c47846ab0e7fb353672d4e24d3637 on maxmind:master.

coveralls commented 10 years ago

Coverage Status

Coverage remained the same when pulling 530a207175486e62dcabbfb0eaa217125d95d0d1 on nrbrook:patch-1 into 8bf84426072c47846ab0e7fb353672d4e24d3637 on maxmind:master.

oschwald commented 10 years ago

Thanks for the report. This should be done in the MaxMind DB repo as GeoIP2 only requires bcmath indirectly.

nrbrook commented 10 years ago

Thanks, I created https://github.com/nrbrook/MaxMind-DB-Reader-php/commit/fbdcbdecd7f606499f391b162cefb25a5eef266c on the MaxMind DB repo