search

maxmind / GeoIP2-python

Python code for GeoIP2 webservice client and database reader
https://geoip2.readthedocs.org/en/latest/
Apache License 2.0
1.1k stars 140 forks source link

Remove mocket #173

Closed shadromani closed 1 month ago

deronnax commented 1 month ago

I'm curious, what's the rational behind the switch from mocket to http-server?

oschwald commented 1 month ago

We unfortunately had quite a few problem with it breaking, e.g., on new or old Python versions, on new aiohttp versions, on particular OSes, etc. If you search the pull requests for "mocket", you will see a subset of those.

We decided to use pytest-httpserver as it implements an actual HTTP server, which should be less prone to these sorts of issues.