search

maxmind / GeoIP2-python

Python code for GeoIP2 webservice client and database reader
https://geoip2.readthedocs.org/en/latest/
Apache License 2.0
1.11k stars 141 forks source link

Pypi rename? #3

Closed cicku closed 10 years ago

cicku commented 10 years ago

Hi folks,

I'm packaging it into Fedora for preparing GeopIP2 landing in Fedora.

However I think this one on pypi has a not good name "geoip2", will you have plan to change it to "GeoIP2" like GeoIP on pypi?

I hope before I build it for Fedora you can change the name to match the name it really is, and this will save our time of renaming packages and blahblahblah in the future(really painful)...

Thank you.

oschwald commented 10 years ago

Sorry, could you explain what is wrong with "geoip2"? PEP8 says:

"Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves readability. Python packages should also have short, all-lowercase names, although the use of underscores is discouraged."

cicku commented 10 years ago

Well, geoip 1 python module on pypi is named python-GeoIP, so I asked this question here.

If you think the current name is good and will be immutable forever, please close this issue.

Thanks.

oschwald commented 10 years ago

I think we will likely stick with "geoip2". The "GeoIP" package name of the legacy API was a mistake.

Thanks for building Fedora packages! :+1: