maxmind / GeoIP2-python

Python code for GeoIP2 webservice client and database reader
https://geoip2.readthedocs.org/en/latest/
Apache License 2.0
1.09k stars 137 forks source link

opening DB and reloading automatically when .mmdb updated #61

Open arrfab opened 5 years ago

arrfab commented 5 years ago

Hi, not sure if that request should be considered an issue, or just some enhancement in the documentation instead. For "legacy" maxmind DB, there was a way to specify some "options", like GeoIP.GEOIP_CHECK_CACHE to force verifying that if underlying DB was changed, it would reopen it automatically , instead of having a relaunch the .py script that has the pointer to the DB.

I don't see option being described in doc, so was wondering what would be the option. help(geoip2.database) seems to have some params, like : MODE_AUTO = 0 MODE_FD = 16 MODE_FILE = 4 MODE_MEMORY = 8 MODE_MMAP = 2 MODE_MMAP_EXT = 1

But I don't know which one would do what I'd need : some py process running in background, and detecting if .mmdb file was changed and would reload it (like GeoIP.GEOIP_CHECK_CACHE was doing for legacy geoip)

oschwald commented 5 years ago

This library doesn't currently support automatic reloading of the database.

arrfab commented 5 years ago

Thanks for the answer .. so is that a case for a RFE then ? as I was using that feature with the "legacy" python-GeoIP pkg, I tried to find the same features level with the new python library.