search

maxmind / MaxMind-DB-Reader-java

Java reader for the MaxMind DB format
https://maxmind.github.io/MaxMind-DB-Reader-java/
Apache License 2.0
114 stars 43 forks source link

Dont use ranges for jackson dependency #28

Closed devshorts closed 7 years ago

devshorts commented 7 years ago

https://github.com/maxmind/MaxMind-DB-Reader-java/blob/v1.2.1/pom.xml#L40

Using a range for the jackson dependency causes snapshots to be pulled in. Maven's range capabilities seems kinda busted, since using a deployed pinned version of MaxMind reader pulls in jackson 2.9.0-SNAPSHOT as of today.

This really messes with your determinism of your artifacts and depending on snapshots is in general bad juju for non-beta libraries.

From the following SO and disucssion the consensus seems to be don't use ranges

oschwald commented 7 years ago

This has already been fixed in 1.2.2.

devshorts commented 7 years ago

@oschwald thanks! Didn't know that, appreciate it :)