maxmind / MaxMind-DB-Reader-python

Python MaxMind DB reader extension
https://maxminddb.readthedocs.org/
Apache License 2.0
178 stars 37 forks source link

Add support for Multi-phase extension module initialization PEP489 #105

Open rcmcdonald91 opened 1 year ago

rcmcdonald91 commented 1 year ago
rcmcdonald91 commented 1 year ago

My first attempt at python extension work, I am addressing failing tests.

In the interim, I have created another PR #106 that directly addresses the missing Py_INCREF issue. #105 needs more work.

rcmcdonald91 commented 1 year ago

This likely requires a broader discussion on the minimum python version we want to support.

oschwald commented 1 year ago

We generally support all Python versions that are still getting security updates upstream. That would mean that we will want to support 3.7 until June.

I haven't looked too closely at the code yet, but it would be fine to conditionally compile blocks of code for particular Python versions.