maxmind / MaxMind-DB-Reader-python

Python MaxMind DB reader extension
https://maxminddb.readthedocs.org/
Apache License 2.0
176 stars 37 forks source link

Python aarch64/arm64 whl releases #152

Closed kpark-hrp closed 5 months ago

kpark-hrp commented 6 months ago

With increasing popularity of M1/M2/M3 and ARM based cloud computing, it would be immensely helpful to also get aarch64/arm64 whl releases.

Thanks!

oschwald commented 6 months ago

I think we will get this automatically once pypa/cibuildwheel supports it. See https://github.com/pypa/cibuildwheel/issues/1746.

kpark-hrp commented 5 months ago

@oschwald It looks like MacOS ARM64 is now supported with this merged PR. https://github.com/pypa/cibuildwheel/pull/1700

And indicated by their README

image
oschwald commented 5 months ago

In that case, this should happen automatically in the next release.

oschwald commented 5 months ago

We just released 2.6.0 and it doesn't seem like they were created. Maybe we need to tweak our build matrix a bit.

kpark-hrp commented 5 months ago

@oschwald I think you need to add macos-14 to the matrix. macos-14 runs on M1, so it covers MacOS arm64.

https://github.com/maxmind/MaxMind-DB-Reader-python/blob/cc3a7090584eded9d8e3b010614ec673eb851138/.github/workflows/release.yml#L19

oschwald commented 5 months ago

Thanks. It looks like you are right. I had no idea that macos-latest meant macos-12. :upside_down_face: