maxmind / MaxMind-DB-Reader-python

Python MaxMind DB reader extension
https://maxminddb.readthedocs.org/
Apache License 2.0
176 stars 37 forks source link

Set include and link dirs explicitly for macOS #162

Closed oschwald closed 4 months ago

ugexe commented 4 months ago

Hmmm. I found https://github.com/actions/runner-images/discussions/9266#discussioncomment-8406444 which mentions:

The problem is that while this maps on X64 for some reason the runner images use the lowercase arm64 rather than following the convention with ARM64. Perhaps this is the issue that needs fixing instead?

So maybe it does need to be arm64, unlike what is mentioned on https://docs.github.com/en/actions/learn-github-actions/variables 😞

oschwald commented 4 months ago

So maybe it does need to be arm64

I am not sure that is the issue. That seems to be running. I thought it might be $env:GITHUB_ENV vs "$GITHUB_ENV", which is mentioned here, but that didn't seem to help.

Edit: actually it was that. I just introduced an unrelated change accidentally.